Cleaning up dart:html generation after interface/implementation merge. Removing most of the interfa…

Cleaning up dart:html generation after interface/implementation merge.

Basically without the interface generation, I moved most of the code-gen into the common base class of dartium and dart2js generation.

I also removed the interface generation files which are no longer being used.

There shouldn't be any changes to the generated files, but the dartium files just got some merged members re-ordered as a by-product of a minor refactoring.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=14691

[vsm, 2012-11-07 22:31:28]

lgtm

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/htmldart...
File sdk/lib/html/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/htmldart...
sdk/lib/html/scripts/htmldartgenerator.py:51: def AddMembers(self, interface,
declare_only=False):
Is declare_only ever True now?

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/htmldart...
sdk/lib/html/scripts/htmldartgenerator.py:94: if isinstance(parent_interface,
str):  # IsDartCollectionType(parent_interface)
nit: line length

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/htmldart...
sdk/lib/html/scripts/htmldartgenerator.py:231: # We only need to secure Window. 
Only local History and Location are returned
nit: line len

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/systemna...
File sdk/lib/html/scripts/systemnative.py (right):

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/systemna...
sdk/lib/html/scripts/systemnative.py:296: dart_declaration = '%s get %s' %
(self.SecureOutputType(attr.type.id), html_name)
length

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/systemna...
sdk/lib/html/scripts/systemnative.py:387:
TYPE=self.SecureOutputType(element_type), INTERFACE=self._interface.id)
length

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/systemna...
sdk/lib/html/scripts/systemnative.py:437: dart_declaration = '%s operator[](int
index)' % self.SecureOutputType(element_type, True)
length

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/systemna...
sdk/lib/html/scripts/systemnative.py:515:
self.SecureOutputType(operation.type.id), overload_name, argument_list)
length

[blois, 2012-11-08 00:08:34]

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/htmldart...
File sdk/lib/html/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/htmldart...
sdk/lib/html/scripts/htmldartgenerator.py:51: def AddMembers(self, interface,
declare_only=False):
On 2012/11/07 22:31:28, vsm wrote:
> Is declare_only ever True now?
Yes, this is used for merged classes in Dartium.

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/htmldart...
sdk/lib/html/scripts/htmldartgenerator.py:94: if isinstance(parent_interface,
str):  # IsDartCollectionType(parent_interface)
On 2012/11/07 22:31:28, vsm wrote:
> nit: line length

Done.

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/htmldart...
sdk/lib/html/scripts/htmldartgenerator.py:231: # We only need to secure Window. 
Only local History and Location are returned
On 2012/11/07 22:31:28, vsm wrote:
> nit: line len

Done.

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/systemna...
File sdk/lib/html/scripts/systemnative.py (right):

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/systemna...
sdk/lib/html/scripts/systemnative.py:296: dart_declaration = '%s get %s' %
(self.SecureOutputType(attr.type.id), html_name)
On 2012/11/07 22:31:28, vsm wrote:
> length

Done.

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/systemna...
sdk/lib/html/scripts/systemnative.py:387:
TYPE=self.SecureOutputType(element_type), INTERFACE=self._interface.id)
On 2012/11/07 22:31:28, vsm wrote:
> length

Done.

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/systemna...
sdk/lib/html/scripts/systemnative.py:437: dart_declaration = '%s operator[](int
index)' % self.SecureOutputType(element_type, True)
On 2012/11/07 22:31:28, vsm wrote:
> length

Done.

https://codereview.chromium.org/11363130/diff/1/sdk/lib/html/scripts/systemna...
sdk/lib/html/scripts/systemnative.py:515:
self.SecureOutputType(operation.type.id), overload_name, argument_list)
On 2012/11/07 22:31:28, vsm wrote:
> length

Done.

[Anton Muhin, 2012-11-08 07:21:31]

STV!

Thanks a lot, Pete.

https://codereview.chromium.org/11363130/diff/34/sdk/lib/html/scripts/htmldar...
File sdk/lib/html/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/11363130/diff/34/sdk/lib/html/scripts/htmldar...
sdk/lib/html/scripts/htmldartgenerator.py:74: # Group overloaded operations by
id
you probably just moved those lines around, but I was under impression that we
require trailing dots in line comments.

If you don't mind, may you add ones here and to comments below?

https://codereview.chromium.org/11363130/diff/34/sdk/lib/html/scripts/htmldar...
sdk/lib/html/scripts/htmldartgenerator.py:233: # returned in generated code.
might be worth an assert

[blois, 2012-11-08 19:19:00]

https://codereview.chromium.org/11363130/diff/34/sdk/lib/html/scripts/htmldar...
File sdk/lib/html/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/11363130/diff/34/sdk/lib/html/scripts/htmldar...
sdk/lib/html/scripts/htmldartgenerator.py:74: # Group overloaded operations by
id
On 2012/11/08 07:21:31, Anton Muhin wrote:
> you probably just moved those lines around, but I was under impression that we
> require trailing dots in line comments.
> 
> If you don't mind, may you add ones here and to comments below?

Done, also flushed out some method documentation as well.

https://codereview.chromium.org/11363130/diff/34/sdk/lib/html/scripts/htmldar...
sdk/lib/html/scripts/htmldartgenerator.py:233: # returned in generated code.
On 2012/11/08 07:21:31, Anton Muhin wrote:
> might be worth an assert

Done.