Issue 11363119: Fix for do/while: if there are phi copies after the condition, emit the non-pretty while loop.

Issue 11363119: Fix for do/while: if there are phi copies after the condition, emit the non-pretty while loop. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for do/while: if there are phi copies after the condition, emit the non-pretty while loop. Committed: https://code.google.com/p/dart/source/detail?r=14616

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -7 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	5 chunks	+26 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language/do_while2_test.dart	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/11363119/diff/4001/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right): https://codereview.chromium.org/11363119/diff/4001/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart#newcode1032 sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1032: CopyHandler handler = variableNames.getCopyHandler(info.end); Add comment explaining why ...

8 years, 1 month ago (2012-11-07 09:59:04 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-07 10:04:49 UTC) #3

Thanks Florian

https://codereview.chromium.org/11363119/diff/4001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/11363119/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1032: CopyHandler
handler = variableNames.getCopyHandler(info.end);
On 2012/11/07 09:59:04, floitsch wrote:
> Add comment explaining why this is necessary.

Done.

https://codereview.chromium.org/11363119/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1034: // Generate
do-while loop in all cases.
On 2012/11/07 09:59:04, floitsch wrote:
> Remove comment or:
> Generate do-while loop in all other cases.

Comment removed.

https://codereview.chromium.org/11363119/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1933: if
(!node.isDoWhile()) {
On 2012/11/07 09:59:04, floitsch wrote:
> Invert the test, so that we don't have the "!".

Done.

Expand Messages | Collapse Messages