Issue 11363076: Add isParameter, change isField to isVariable on MemberMirror

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11363076: Add isParameter, change isField to isVariable on MemberMirror (Closed)

Created:
8 years, 1 month ago by Johnni Winther

Modified:
8 years, 1 month ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org, turnidge, Andrei Mouravski

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add isParameter, change isField to isVariable on MemberMirror Committed: https://code.google.com/p/dart/source/detail?r=14516

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -14 lines)			Patch
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/mirrors.dart	View	1 chunk	+14 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/src/mirrors/dart2js_mirror.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/mirrors_test.dart	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

ahe

8 years, 1 month ago (2012-11-05 10:01:49 UTC) #2

LGTM! Generally, these kind of changes would be nice to have in dart2js sources
as well.