Issue 11363039: Reverting a performance optimization - I'm not comfortable it's side-effect free.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11363039: Reverting a performance optimization - I'm not comfortable it's side-effect free. (Closed)

Created:
8 years, 1 month ago by devoncarew

Modified:
8 years, 1 month ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Reverting a performance optimization - I'm not comfortable it's side-effect free. Committed: https://code.google.com/p/dart/source/detail?r=14428

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	compiler/java/com/google/dart/compiler/ast/DartNode.java	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 1 month ago (2012-11-01 18:10:18 UTC) #3

LGTM. The only problem I can see with it is that changes to
DartIdentifier.accept() would need to be duplicated here, but it's certainly
safer to not introduce the possibility for skew.

Expand Messages | Collapse Messages