Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 11363037: Do not evaluate arguments of an instance send if that instance send is being inlined. The inliner w… (Closed)

Created:
8 years, 1 month ago by ngeoffray
Modified:
8 years, 1 month ago
Reviewers:
floitsch, kasperl
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Do not evaluate arguments of an instance send if that instance send is being inlined. The inliner will take care of evaluating them. Committed: https://code.google.com/p/dart/source/detail?r=14430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M lib/compiler/implementation/ssa/builder.dart View 2 chunks +7 lines, -7 lines 0 comments Download
A tests/language/inline_argument_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
8 years, 1 month ago (2012-11-01 16:24:34 UTC) #1
floitsch
8 years, 1 month ago (2012-11-01 17:00:49 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698