Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11363035: Roll IDLs forward. (Closed)

Created:
8 years, 1 month ago by Anton Muhin
Modified:
8 years, 1 month ago
Reviewers:
vsm, Emily Fortuna, sra1, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -172 lines) Patch
M lib/html/dart2js/html_dart2js.dart View 16 chunks +75 lines, -43 lines 3 comments Download
M lib/html/dartium/html_dartium.dart View 16 chunks +54 lines, -47 lines 0 comments Download
M third_party/WebCore/Modules/indexeddb/IDBCursor.idl View 1 chunk +3 lines, -3 lines 1 comment Download
M third_party/WebCore/Modules/indexeddb/IDBCursorWithValue.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebCore/Modules/intents/DOMWindowIntents.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebCore/Modules/mediasource/MediaSource.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebCore/Modules/mediastream/RTCPeerConnection.idl View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebCore/Modules/webaudio/AudioBufferSourceNode.idl View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebCore/Modules/webaudio/AudioContext.idl View 2 chunks +12 lines, -3 lines 0 comments Download
M third_party/WebCore/Modules/webaudio/AudioParam.idl View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebCore/README View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebCore/bindings/scripts/test/TestObj.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebCore/html/HTMLBaseElement.idl View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebCore/html/HTMLInputElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebCore/inspector/InspectorFrontendHost.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebCore/page/DOMWindow.idl View 7 chunks +33 lines, -33 lines 3 comments Download
M third_party/WebCore/page/History.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebCore/storage/Storage.idl View 1 chunk +9 lines, -5 lines 0 comments Download
M third_party/WebCore/testing/InternalSettings.idl View 4 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebCore/testing/Internals.idl View 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebCore/workers/WorkerContext.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebCore/xml/XMLHttpRequest.idl View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Anton Muhin
8 years, 1 month ago (2012-11-01 15:01:27 UTC) #1
blois
https://codereview.chromium.org/11363035/diff/1/lib/html/dart2js/html_dart2js.dart File lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/11363035/diff/1/lib/html/dart2js/html_dart2js.dart#oldcode15359 lib/html/dart2js/html_dart2js.dart:15359: - dynamic get _primaryKey => JS("dynamic", "#.primaryKey", this); Is ...
8 years, 1 month ago (2012-11-01 16:13:20 UTC) #2
Anton Muhin
https://codereview.chromium.org/11363035/diff/1/lib/html/dart2js/html_dart2js.dart File lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/11363035/diff/1/lib/html/dart2js/html_dart2js.dart#oldcode15359 lib/html/dart2js/html_dart2js.dart:15359: - dynamic get _primaryKey => JS("dynamic", "#.primaryKey", this); On ...
8 years, 1 month ago (2012-11-01 16:16:39 UTC) #3
blois
You can go ahead with the change, we'll investigate the IDBKey change. (The IDL changed ...
8 years, 1 month ago (2012-11-01 16:21:56 UTC) #4
sra1
https://codereview.chromium.org/11363035/diff/1/lib/html/dart2js/html_dart2js.dart File lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/11363035/diff/1/lib/html/dart2js/html_dart2js.dart#oldcode15359 lib/html/dart2js/html_dart2js.dart:15359: - dynamic get _primaryKey => JS("dynamic", "#.primaryKey", this); On ...
8 years, 1 month ago (2012-11-01 16:26:53 UTC) #5
Emily Fortuna
https://codereview.chromium.org/11363035/diff/1/third_party/WebCore/Modules/indexeddb/IDBCursor.idl File third_party/WebCore/Modules/indexeddb/IDBCursor.idl (right): https://codereview.chromium.org/11363035/diff/1/third_party/WebCore/Modules/indexeddb/IDBCursor.idl#newcode36 third_party/WebCore/Modules/indexeddb/IDBCursor.idl:36: readonly attribute any key; This is probably why the ...
8 years, 1 month ago (2012-11-01 16:32:26 UTC) #6
Anton Muhin
8 years, 1 month ago (2012-11-01 16:45:08 UTC) #7 
https://codereview.chromium.org/11363035/diff/1/third_party/WebCore/page/DOMW...
File third_party/WebCore/page/DOMWindow.idl (right):

https://codereview.chromium.org/11363035/diff/1/third_party/WebCore/page/DOMW...
third_party/WebCore/page/DOMWindow.idl:93: [Replaceable] readonly attribute 
boolean offscreenBuffering;
On 2012/11/01 16:32:26, Emily Fortuna wrote:
> nit: extra space between attribute and boolean.

Those brought verbatim from WebKit, I don't think we should modify them.

Powered by Google App Engine
This is Rietveld 408576698