Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issue 11363012: Prevent mutation of final variables (Closed)

Created:
8 years, 1 month ago by hausner
Modified:
8 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Prevent mutation of final variables Fixes issue 4328 Committed: https://code.google.com/p/dart/source/detail?r=14366

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M pkg/pkg.status View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/ast.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 3 chunks +6 lines, -1 line 0 comments Download
A tests/language/final_variable_assignment_test.dart View 1 1 chunk +13 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
8 years, 1 month ago (2012-10-31 16:42:09 UTC) #1
srdjan
LGTM after adding tests.
8 years, 1 month ago (2012-10-31 17:33:22 UTC) #2
hausner
8 years, 1 month ago (2012-10-31 19:38:54 UTC) #3
Thanks. Not sure how my change fixed the pkg tests.

Powered by Google App Engine
This is Rietveld 408576698