Issue 11363007: Properties added to MethodMirror

Issue 11363007: Properties added to MethodMirror (Closed)

Created:
8 years, 1 month ago by Johnni Winther

Modified:
8 years, 1 month ago

Reviewers:
ahe, kasperl

CC:
reviews_dartlang.org, turnidge

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Properties added to MethodMirror Committed: https://code.google.com/p/dart/source/detail?r=14339

Patch Set 2 : Updated cf. comment #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -101 lines)			Patch
M	pkg/dartdoc/lib/dartdoc.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/dartdoc/lib/mirrors.dart	View		1 chunk	+24 lines, -5 lines	1 comment	Download
M	pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart	View	1	6 chunks	+19 lines, -9 lines	1 comment	Download
M	tests/compiler/dart2js/mirrors_test.dart	View		8 chunks	+121 lines, -85 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/11363007/diff/1/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right): https://codereview.chromium.org/11363007/diff/1/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart#newcode117 pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:117: = const Dart2JsMethodKind("generative"); Nit: I'd prefer keeping = ...

8 years, 1 month ago (2012-10-31 13:35:47 UTC) #2

Johnni Winther

https://codereview.chromium.org/11363007/diff/1/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right): https://codereview.chromium.org/11363007/diff/1/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart#newcode117 pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:117: = const Dart2JsMethodKind("generative"); On 2012/10/31 13:35:47, kasperl wrote: > ...

8 years, 1 month ago (2012-10-31 13:49:02 UTC) #3

ahe

8 years, 1 month ago (2012-11-06 10:07:47 UTC) #4

LGTM

https://codereview.chromium.org/11363007/diff/3002/pkg/dartdoc/lib/mirrors.dart
File pkg/dartdoc/lib/mirrors.dart (right):

https://codereview.chromium.org/11363007/diff/3002/pkg/dartdoc/lib/mirrors.da...
pkg/dartdoc/lib/mirrors.dart:470: * regular methods.
What about factories?

https://codereview.chromium.org/11363007/diff/3002/pkg/dartdoc/lib/src/mirror...
File pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart (right):

https://codereview.chromium.org/11363007/diff/3002/pkg/dartdoc/lib/src/mirror...
pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart:1391: => isGenerativeConstructor
|| isConstConstructor ||
As a matter of style, I prefer to avoid using => short-hand when it doesn't fit
on one line.

Expand Messages | Collapse Messages