Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 11363005: ObjectMirror => ContainerMirror (Closed)

Created:
8 years, 1 month ago by Johnni Winther
Modified:
8 years, 1 month ago
Reviewers:
ahe, kasperl
CC:
reviews_dartlang.org, Andrei Mouravski, turnidge
Visibility:
Public.

Description

ObjectMirror => ContainerMirror declaredMembers => members Committed: https://code.google.com/p/dart/source/detail?r=14325

Patch Set 1 #

Patch Set 2 : Test updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -72 lines) Patch
M pkg/dartdoc/lib/dartdoc.dart View 20 chunks +20 lines, -20 lines 0 comments Download
M pkg/dartdoc/lib/mirrors.dart View 3 chunks +13 lines, -13 lines 0 comments Download
M pkg/dartdoc/lib/mirrors_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart View 1 10 chunks +15 lines, -24 lines 0 comments Download
M tests/compiler/dart2js/mirrors_test.dart View 1 5 chunks +11 lines, -13 lines 0 comments Download
M utils/apidoc/html_diff.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
8 years, 1 month ago (2012-10-31 10:12:21 UTC) #1
kasperl
LGTM.
8 years, 1 month ago (2012-10-31 10:30:58 UTC) #2
ahe
8 years, 1 month ago (2012-11-06 15:20:12 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698