Issue 11362172: Temporarily skip arithmetic_test for dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11362172: Temporarily skip arithmetic_test for dart2js. (Closed)

Created:
8 years, 1 month ago by Florian Schneider

Modified:
8 years, 1 month ago

Reviewers:
ngeoffray, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Temporarily skip arithmetic_test for dart2js. There is a bug in left-shift by 0. TBR=ngeoffray@google.com, BUG=dart:6627 TEST=tests/language/arithmetic_test.dart Committed: https://code.google.com/p/dart/source/detail?r=14713

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/language/language_dart2js.status	View		1 chunk	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Is this a known issue? I filed http://code.google.com/p/dart/issues/detail?id=6627

8 years, 1 month ago (2012-11-08 23:43:04 UTC) #1

srdjan

DBC https://codereview.chromium.org/11362172/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/11362172/diff/1/tests/language/language_dart2js.status#newcode35 tests/language/language_dart2js.status:35: arithmetic_test: Skip Instead of Skip use: Fail # ...

8 years, 1 month ago (2012-11-09 00:11:20 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-09 08:33:30 UTC) #3

https://codereview.chromium.org/11362172/diff/1/tests/language/language_dart2...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11362172/diff/1/tests/language/language_dart2...
tests/language/language_dart2js.status:35: arithmetic_test: Skip
On 2012/11/09 00:11:20, srdjan wrote:
> Instead of Skip use: Fail # Issue 6627

+1

Expand Messages | Collapse Messages