Issue 11362065: Add KeyCode enumeration in Dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11362065: Add KeyCode enumeration in Dart. (Closed)

Created:
8 years, 1 month ago by Emily Fortuna

Modified:
8 years, 1 month ago

Reviewers:
Jennifer Messerly, blois

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add KeyCode enumeration in Dart and fix path of html lib script after sdk move. Committed: https://code.google.com/p/dart/source/detail?r=14504

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+587 lines, -2 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+193 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+193 lines, -0 lines	0 comments	Download
M	sdk/lib/html/scripts/dartdomgenerator.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/html/scripts/fremontcutbuilder.py	View		1 chunk	+1 line, -1 line	0 comments	Download
A	sdk/lib/html/src/KeyCode.dart	View	1	1 chunk	+196 lines, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/dart2js/html_dart2js.darttemplate	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/templates/html/dartium/html_dartium.darttemplate	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

The very first of many keyboard CLs. (and fixing up html lib generation after the ...

8 years, 1 month ago (2012-11-02 22:40:45 UTC) #1

Jennifer Messerly

lgtm! https://codereview.chromium.org/11362065/diff/2001/sdk/lib/html/src/KeyCode.dart File sdk/lib/html/src/KeyCode.dart (right): https://codereview.chromium.org/11362065/diff/2001/sdk/lib/html/src/KeyCode.dart#newcode5 sdk/lib/html/src/KeyCode.dart:5: /** Might be worth a comment (in the ...

8 years, 1 month ago (2012-11-02 22:46:17 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 11362065: Add KeyCode enumeration in Dart. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages