Issue 11362013: Fixed build break by updating expectation of tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11362013: Fixed build break by updating expectation of tests. (Closed)

Created:
8 years, 1 month ago by Andrei Mouravski

Modified:
8 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixed build break by updating expectation of tests. Some tests were marked as fail OK, but now the underlying problem is fixed. Committed: https://code.google.com/p/dart/source/detail?r=14351

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	pkg/pkg.status	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

regis

No reviewer? You should remove passing tests from the status file, not mark them as ...

8 years, 1 month ago (2012-10-31 17:18:44 UTC) #1

Andrei Mouravski

8 years, 1 month ago (2012-10-31 17:23:02 UTC) #2

On 2012/10/31 17:18:44, regis wrote:
> No reviewer?
> 
> You should remove passing tests from the status file, not mark them as 'Pass'.
> 
> Cheers,
> Regis

I'm sorry! I didn't know how that file worked, necessarily, but it fixed the
issue, so I went with it. I'll know for next time.

Expand Messages | Collapse Messages