New APIs for external byte arrays

New APIs for external byte arrays

The following APIs have been added:

Dart_IsExternalByteArray: Check whether an object is an external byte
array.

Dart_ExternalByteArrayGetData: Return the pointer to the external data
hosted by the external byte array.

R=cshapiro@google.com

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=14380

[Søren Gjesse, 2012-10-31 12:56:56]

I am not quite sure about the handling of external arrays of type other than
Uint8. Seems that there is currently no API to create these.

[cshapiro, 2012-11-01 00:36:35]

LGTM with comments.  Please make corrections before submitting.

In the future there will be separate constructors for the external and
non-external Int, Float and Uint types.

I would like the IsByteArray predicate to return true for all of these types.  I
would like IsByteArrayExternal to return true for just the external types.  This
mirrors the naming with strings where we have IsString and IsString8, etc.

[cshapiro, 2012-11-01 00:40:19]

not sure why this didn't take the first time...

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h#new...
runtime/include/dart_api.h:1623: 
Remove this line.  1 space between definitions in this header.

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h#new...
runtime/include/dart_api.h:1630: DART_EXPORT bool
Dart_IsExternalByteArray(Dart_Handle object);
I would prefer this to be named Dart_IsByteArrayExternal.

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h#new...
runtime/include/dart_api.h:1632: 
Remove this line.  1 space between definitions in this header.

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h#new...
runtime/include/dart_api.h:1643: 
1 space between definitions in this header.

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h#new...
runtime/include/dart_api.h:1665: 
1 space between definitions in this header.

http://codereview.chromium.org/11362009/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/11362009/diff/1/runtime/vm/dart_api_impl.cc#ne...
runtime/vm/dart_api_impl.cc:2185: 
Remove this addition.  Only 2 spaces between definitions in this file.

[Søren Gjesse, 2012-11-01 07:46:03]

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h#new...
runtime/include/dart_api.h:1623: 
On 2012/11/01 00:40:19, cshapiro wrote:
> Remove this line.  1 space between definitions in this header.

Done.

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h#new...
runtime/include/dart_api.h:1630: DART_EXPORT bool
Dart_IsExternalByteArray(Dart_Handle object);
On 2012/11/01 00:40:19, cshapiro wrote:
> I would prefer this to be named Dart_IsByteArrayExternal.

Done.

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h#new...
runtime/include/dart_api.h:1632: 
On 2012/11/01 00:40:19, cshapiro wrote:
> Remove this line.  1 space between definitions in this header.

Done.

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h#new...
runtime/include/dart_api.h:1643: 
On 2012/11/01 00:40:19, cshapiro wrote:
> 1 space between definitions in this header.

Done.

http://codereview.chromium.org/11362009/diff/1/runtime/include/dart_api.h#new...
runtime/include/dart_api.h:1665: 
On 2012/11/01 00:40:19, cshapiro wrote:
> 1 space between definitions in this header.

Done.

http://codereview.chromium.org/11362009/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/11362009/diff/1/runtime/vm/dart_api_impl.cc#ne...
runtime/vm/dart_api_impl.cc:2185: 
On 2012/11/01 00:40:19, cshapiro wrote:
> Remove this addition.  Only 2 spaces between definitions in this file.

Done.

[Søren Gjesse, 2012-11-01 07:52:13]

Thanks for the review - sorry for the white space mess.