Issue 11361262: Add some makefiles generated by gyp for newly added targets to .gitignore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11361262: Add some makefiles generated by gyp for newly added targets to .gitignore. (Closed)

Created:
8 years, 1 month ago by Bill Hesse

Modified:
8 years, 1 month ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add some makefiles generated by gyp for newly added targets to .gitignore. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14900

Patch Set 1 #

Patch Set 2 : remove blank line at end of file #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
M	compiler/.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	runtime/bin/net/.gitignore	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	samples/sample_extension/.gitignore	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

There are some files the root directory (targets of dart.gyp), but that .gitignore is generated ...

8 years, 1 month ago (2012-11-14 16:41:28 UTC) #3

Bob Nystrom

8 years, 1 month ago (2012-11-14 18:00:23 UTC) #4

On 2012/11/14 16:41:28, Bill Hesse wrote:
> There are some files the root directory (targets of dart.gyp), but that
> .gitignore is generated from the SVN propeties, so I will fix that after I fix
> the SVN properties for these new targets.

How about just adding "*.mk" to the top-level .gitignore? Listing them all
specifically seems a bit gratuitous.

Expand Messages | Collapse Messages