Issue 11361257: Support corelib tests in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11361257: Support corelib tests in checked mode. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
ahe, karlklose

CC:
reviews_dartlang.org, erikcorry

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support corelib tests in checked mode. Committed: https://code.google.com/p/dart/source/detail?r=14882

Patch Set 3 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/interceptors.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. http://codereview.chromium.org/11361257/diff/5001/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): http://codereview.chromium.org/11361257/diff/5001/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode923 sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:923: // A class that defines a [:call:] method ...

8 years, 1 month ago (2012-11-14 12:03:04 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-14 12:03:49 UTC) #3

Thanks Karl

http://codereview.chromium.org/11361257/diff/5001/sdk/lib/_internal/compiler/...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

http://codereview.chromium.org/11361257/diff/5001/sdk/lib/_internal/compiler/...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:923: // A
class that defines a [:call:] method implicitly implement
On 2012/11/14 12:03:04, karlklose wrote:
> 'implement' -> 'implements'.

Done.

Expand Messages | Collapse Messages

Issue 11361257: Support corelib tests in checked mode. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Messages