Fix bug 6586:

Fix bug 6586:
- Attempt to run the Monitor thread_test multiple times before failing
  due to its potential to failure due to timing.
- Use named constants when converting millis to seconds and nanos.
Committed: https://code.google.com/p/dart/source/detail?r=14695

[siva, 2012-11-07 23:41:02]

lgtm

https://chromiumcodereview.appspot.com/11361157/diff/4001/runtime/vm/thread_t...
File runtime/vm/thread_test.cc (right):

https://chromiumcodereview.appspot.com/11361157/diff/4001/runtime/vm/thread_t...
runtime/vm/thread_test.cc:56: OS::Print("wakeup_time: %"Pd64"\n", wakeup_time);
Is this print statement needed?

https://chromiumcodereview.appspot.com/11361157/diff/4001/runtime/vm/thread_t...
runtime/vm/thread_test.cc:67: OS::Print("Failed %d consecutive attempts.\n",
kNumAttempts);
OS::Print("Monitor.wait test failed %d.....

[Ivan Posva, 2012-11-08 18:01:07]

https://codereview.chromium.org/11361157/diff/4001/runtime/vm/thread_test.cc
File runtime/vm/thread_test.cc (right):

https://codereview.chromium.org/11361157/diff/4001/runtime/vm/thread_test.cc#...
runtime/vm/thread_test.cc:56: OS::Print("wakeup_time: %"Pd64"\n", wakeup_time);
On 2012/11/07 23:41:02, siva wrote:
> Is this print statement needed?

It is needed to be able to figure out the wakeup times when failing.

https://codereview.chromium.org/11361157/diff/4001/runtime/vm/thread_test.cc#...
runtime/vm/thread_test.cc:67: OS::Print("Failed %d consecutive attempts.\n",
kNumAttempts);
On 2012/11/07 23:41:02, siva wrote:
> OS::Print("Monitor.wait test failed %d.....

The test harness around it identifies the test.  I am changing this to a proper
EXPECT instead of EXPECT(false).

[Ivan Posva, 2012-11-08 18:07:39]

Updated and removed the test from being flaky in the status.

-Ivan