Keep track of the request and response state in the HTTP client connection

Keep track of the request and response state in the HTTP client connection

In a HTTP client connection it is possible for the response to end
before the request has been fully sent. This situation was not handled
correctly. Now the HTTP client connection keeps track of the state of
both request and response and doen not end the client connection
before both are done.

R=ager@google.com

BUG=dart:6521
Committed: https://code.google.com/p/dart/source/detail?r=14559

[Mads Ager (google), 2012-11-06 09:30:57]

LGTM

https://codereview.chromium.org/11361119/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11361119/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1980: bool get _isRequestDone => (_state &
REQUEST_DONE) == REQUEST_DONE;
Maybe remove 'is' from all of these?

if (requestDone) ...;

https://codereview.chromium.org/11361119/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1996: _pendingRetry = null;
Should we move the resetting of these to null into the branches above? Or maybe
add an assert that we never have both _pendingRedirect and _pendingRetry?

https://codereview.chromium.org/11361119/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:2102: if (_isAllDone) {
Maybe add a comment to retry and redirect that we postpone the actual
retry/redirect until both request and response are done.

[Søren Gjesse, 2012-11-06 11:28:46]

https://codereview.chromium.org/11361119/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11361119/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1980: bool get _isRequestDone => (_state &
REQUEST_DONE) == REQUEST_DONE;
On 2012/11/06 09:30:57, Mads Ager wrote:
> Maybe remove 'is' from all of these?
> 
> if (requestDone) ...;

I would have liked this as well. However there is already a method called
_requestDone.

https://codereview.chromium.org/11361119/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1996: _pendingRetry = null;
On 2012/11/06 09:30:57, Mads Ager wrote:
> Should we move the resetting of these to null into the branches above? Or
maybe
> add an assert that we never have both _pendingRedirect and _pendingRetry?

Done (both).

https://codereview.chromium.org/11361119/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:2102: if (_isAllDone) {
On 2012/11/06 09:30:57, Mads Ager wrote:
> Maybe add a comment to retry and redirect that we postpone the actual
> retry/redirect until both request and response are done.

Done.