Issue 11361100: Remove hack around aborting loop body in the case of for loops and while loops.

Issue 11361100: Remove hack around aborting loop body in the case of for loops and while loops. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove hack around aborting loop body in the case of for loops and while loops. Committed: https://code.google.com/p/dart/source/detail?r=14555

Patch Set 4 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -44 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	5 chunks	+65 lines, -41 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/dart2js.status	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/11361100/diff/3001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/11361100/diff/3001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode1820 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1820: // update block is the jump-target for continue ...

8 years, 1 month ago (2012-11-05 17:36:08 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-06 08:55:27 UTC) #3

Thanks Florian

https://codereview.chromium.org/11361100/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11361100/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1820: // update block
is the jump-target for continue statements. We could avoid
On 2012/11/05 17:36:09, floitsch wrote:
> It seems trivial to avoid the creation of the block if there are no continues.
> But fine with doing that in a separate CL.

Will do in another CL.

https://codereview.chromium.org/11361100/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart
(right):

https://codereview.chromium.org/11361100/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/variable_allocator.dart:299:
assert(header.predecessors.length == 1);
On 2012/11/05 17:36:09, floitsch wrote:
> add comment what happened.

I changed the code to not enter updateLoopMarker in case the loop header does
not have back edge. And added a comment there.

Expand Messages | Collapse Messages