Issue 11361035: Fix a LICM bug where we were loop hoisting an isntruction, even though that isntruction's inputs we…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11361035: Fix a LICM bug where we were loop hoisting an isntruction, even though that isntruction's inputs we… (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix a LICM bug where we were loop hoisting an isntruction, even though that isntruction's inputs were changed before. Committed: https://code.google.com/p/dart/source/detail?r=14414

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -5 lines)			Patch
M	lib/compiler/implementation/ssa/optimize.dart	View	1	2 chunks	+8 lines, -3 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
A	tests/language/licm_test.dart	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Turns out, we already had the list of blocks that are in the loop :)

8 years, 1 month ago (2012-11-01 13:57:44 UTC) #1

kasperl

LGTM! https://codereview.chromium.org/11361035/diff/1/lib/compiler/implementation/ssa/optimize.dart File lib/compiler/implementation/ssa/optimize.dart (right): https://codereview.chromium.org/11361035/diff/1/lib/compiler/implementation/ssa/optimize.dart#newcode908 lib/compiler/implementation/ssa/optimize.dart:908: HBasicBlock preheader = loopHeader.predecessors[0]; Maybe assert that block ...

8 years, 1 month ago (2012-11-01 14:00:17 UTC) #2