Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 11361010: Fix bug in invocation_mirror_test wrt. setters. (Closed)

Created:
8 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
8 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug in invocation_mirror_test wrt. setters. A setter call will not evaluate to the return value of the noSuchMethod. Committed: https://code.google.com/p/dart/source/detail?r=14382

Patch Set 1 #

Patch Set 2 : Added error messages. Fixed two typos. #

Patch Set 3 : Added more tests and documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -34 lines) Patch
M tests/language/invocation_mirror_test.dart View 1 2 8 chunks +80 lines, -34 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein Nielsen
8 years, 1 month ago (2012-10-31 15:27:22 UTC) #1
Anders Johnsen
8 years, 1 month ago (2012-11-01 07:19:06 UTC) #2
LGTM, but I'm quite unfamiliar with this area.

Powered by Google App Engine
This is Rietveld 408576698