Issue 11360051: Make library, import, export, part built-in identifiers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11360051: Make library, import, export, part built-in identifiers (Closed)

Created:
8 years, 1 month ago by hausner

Modified:
8 years, 1 month ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make library, import, export, part built-in identifiers Committed: https://code.google.com/p/dart/source/detail?r=14446

Patch Set 4 : #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -33 lines)			Patch
M	runtime/vm/parser.cc	View	1 2 3	9 chunks	+16 lines, -18 lines	0 comments	Download
M	runtime/vm/scanner.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/token.h	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View		4 chunks	+2 lines, -6 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/language/pseudo_kw_illegal_test.dart	View		2 chunks	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

DBC -ip https://codereview.chromium.org/11360051/diff/8008/tests/language/pseudo_kw_illegal_test.dart File tests/language/pseudo_kw_illegal_test.dart (right): https://codereview.chromium.org/11360051/diff/8008/tests/language/pseudo_kw_illegal_test.dart#newcode18 tests/language/pseudo_kw_illegal_test.dart:18: class part { } /// 17: compile-time ...

8 years, 1 month ago (2012-11-01 23:55:35 UTC) #3

hausner

8 years, 1 month ago (2012-11-02 00:36:36 UTC) #4

https://codereview.chromium.org/11360051/diff/8008/tests/language/pseudo_kw_i...
File tests/language/pseudo_kw_illegal_test.dart (right):

https://codereview.chromium.org/11360051/diff/8008/tests/language/pseudo_kw_i...
tests/language/pseudo_kw_illegal_test.dart:18: class part { }        /// 17:
compile-time error
On 2012/11/01 23:55:35, Ivan Posva wrote:
> Isn't this masked by the earlier compile-time error labeled 17?

Oops, will correct this when I resubmit the change.

Expand Messages | Collapse Messages

Issue 11360051: Make library, import, export, part built-in identifiers (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages