Only start http server for browser tests.

Only start http server for browser tests.

This reduces the annoyance of the fixed port number used and allows
non-browser test configurations to be run in parallel (or one browser
configuration in parallel with a bunch of non-browser configurations).

R=ahe@google.com,ricow@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=14403

[ricow1, 2012-11-01 09:48:55]

https://codereview.chromium.org/11360028/diff/1/tools/test-runtime.dart
File tools/test-runtime.dart (right):

https://codereview.chromium.org/11360028/diff/1/tools/test-runtime.dart#newco...
tools/test-runtime.dart:101: print(runningBrowserTests);
debug print?

https://codereview.chromium.org/11360028/diff/1/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/11360028/diff/1/tools/test.dart#newcode144
tools/test.dart:144: () => terminateHttpServer(),
don't you still need to wrap this and only do it if (!listTests)
Alternatively, make terminateHttpServer more robust by checking that the server
is not null before calling close

[Mads Ager (google), 2012-11-01 10:12:57]

https://codereview.chromium.org/11360028/diff/1/tools/test-runtime.dart
File tools/test-runtime.dart (right):

https://codereview.chromium.org/11360028/diff/1/tools/test-runtime.dart#newco...
tools/test-runtime.dart:101: print(runningBrowserTests);
On 2012/11/01 09:48:55, ricow1 wrote:
> debug print?

Done.

https://codereview.chromium.org/11360028/diff/1/tools/test.dart
File tools/test.dart (right):

https://codereview.chromium.org/11360028/diff/1/tools/test.dart#newcode144
tools/test.dart:144: () => terminateHttpServer(),
On 2012/11/01 09:48:55, ricow1 wrote:
> don't you still need to wrap this and only do it if (!listTests)
> Alternatively, make terminateHttpServer more robust by checking that the
server
> is not null before calling close

I already did that. Have a look at http_server.dart.

[ricow1, 2012-11-01 12:56:20]

LGTM

[ahe, 2012-11-01 13:06:40]

LGTM