Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 11360015: "Reverting 14361" to fix a break. (Closed)

Created:
8 years, 1 month ago by Andrei Mouravski
Modified:
8 years, 1 month ago
Reviewers:
gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

"Reverting 14361" to fix a break. Committed: https://code.google.com/p/dart/source/detail?r=14370

Patch Set 1 #

Patch Set 2 : Chmodded. #

Patch Set 3 : Re-reverted mirrors.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M pkg/dartdoc/test/dartdoc_search_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dartdoc/test/dartdoc_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/dartdoc/test/markdown_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A tools/revert.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Andrei Mouravski
Sorry to keep bothering you, I'm going to revert this and then fix things correctly.
8 years, 1 month ago (2012-10-31 20:13:11 UTC) #1
Emily Fortuna
lgtm
8 years, 1 month ago (2012-10-31 20:18:44 UTC) #2
gram
8 years, 1 month ago (2012-10-31 20:18:47 UTC) #3
Remove the dart2js... file from the CL.

Else LGTM.

Powered by Google App Engine
This is Rietveld 408576698