Allow tests to specify a package root.

Allow tests to specify a package root.

Use a shared package root if none is specified.

Committed: https://code.google.com/p/dart/source/detail?r=15064

Committed: https://code.google.com/p/dart/source/detail?r=15070

[Bob Nystrom, 2012-11-13 19:58:59]

LGTM, minus the "DO NOT SUBMIT" part, of course.

[Bob Nystrom, 2012-11-15 18:25:39]

What's the status of this patch?

This is blocking me from making progress on several M2 issues for pub, and is
also preventing us from hosting the packages in pkg on pub.dartlang.org.

[dgrove, 2012-11-15 19:45:46]

On 2012/11/15 19:25:52, Bob Nystrom wrote:

It would be very helpful to get this in soon. Is there anything that we in
Seattle can do to help with this?

[ahe, 2012-11-16 07:29:08]

Still work in progress, but please take a look at the new PackageRoot test file
variable and let me know if you think it is a problem adding that.

https://codereview.chromium.org/11359187/diff/1/dart/tests/html/url_test.dart
File dart/tests/html/url_test.dart (right):

https://codereview.chromium.org/11359187/diff/1/dart/tests/html/url_test.dart...
dart/tests/html/url_test.dart:7: import 'package:unittest/html_config.dart';
Will not submit these changes.  Only for testing.

https://codereview.chromium.org/11359187/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11359187/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_suite.dart:932: // TODO(ahe): DO NOT SUBMIT,
DumpRenderTree hangs on package: imports.
I have since learned that I should use an environment variable instead
DART_PACKAGE_ROOT.  It is a little bit tricky as the environment variable
depends on the configuration, so we have to pass it through to
drt-trampoline.py, rather than just setting it globally.

[Mads Ager (google), 2012-11-16 09:11:57]

I don't think the variable is a big problem but I would prefer not to have it.
Are the tests you have updated here the only ones that need it? It seems those
tests are very simple package-root tests for the VM. Maybe they can be replaced
with new tests using the stuff you are putting in now to just check that you can
load some of the pkg packages via package urls?

[ahe, 2012-11-16 12:58:52]

Success with:

DART_PACKAGE_ROOT=file:///Users/ahe/Dart/all/dart/xcodebuild/ReleaseIA32/packages/
./tools/test.py -mrelease pkg/args -rdrt -v

Hopefully, I should be able to finish this on Monday.  The key is to use an
absolute file URI.

[ahe, 2012-11-19 07:49:28]

PTAL

As we discussed, we do need to be able to test package root options, so I think
the PackageRoot file option makes sense.

In particular, I would like to write a test that puts something in the default
direction ("packages"), and test that it gets different results when setting the
PackageRoot.

[Mads Ager (google), 2012-11-19 09:03:30]

LGTM

https://codereview.chromium.org/11359187/diff/5003/dart/tools/testing/drt-tra...
File dart/tools/testing/drt-trampoline.py (right):

https://codereview.chromium.org/11359187/diff/5003/dart/tools/testing/drt-tra...
dart/tools/testing/drt-trampoline.py:60: print env
Is this print helpful on the bots or is it left-over debug printing?

[ahe, 2012-11-19 09:40:39]

Bob, Mads,

Thank you for taking a look.

Cheers,
Peter

https://codereview.chromium.org/11359187/diff/5003/dart/tools/testing/drt-tra...
File dart/tools/testing/drt-trampoline.py (right):

https://codereview.chromium.org/11359187/diff/5003/dart/tools/testing/drt-tra...
dart/tools/testing/drt-trampoline.py:60: print env
On 2012/11/19 09:03:30, Mads Ager wrote:
> Is this print helpful on the bots or is it left-over debug printing?

Leftover debugging.  Removed.

[ahe, 2012-11-19 11:27:28]

PTAL at patch set 6.

[Mads Ager (google), 2012-11-19 11:32:03]

lgtm with your own comments that I have typed into the review. :-)

https://codereview.chromium.org/11359187/diff/13002/dart/tools/make_links.py
File dart/tools/make_links.py (right):

https://codereview.chromium.org/11359187/diff/13002/dart/tools/make_links.py#...
dart/tools/make_links.py:27: bug_cleanup = os.path.join(target, 'lib')
source

https://codereview.chromium.org/11359187/diff/13002/dart/tools/make_links.py#...
dart/tools/make_links.py:29: os.unlink(target)
bug_cleanup

[ahe, 2012-11-19 11:35:45]

Thank you, Mads!

https://codereview.chromium.org/11359187/diff/13002/dart/tools/make_links.py
File dart/tools/make_links.py (right):

https://codereview.chromium.org/11359187/diff/13002/dart/tools/make_links.py#...
dart/tools/make_links.py:27: bug_cleanup = os.path.join(target, 'lib')
On 2012/11/19 11:32:03, Mads Ager wrote:
> source

Done.

https://codereview.chromium.org/11359187/diff/13002/dart/tools/make_links.py#...
dart/tools/make_links.py:29: os.unlink(target)
On 2012/11/19 11:32:03, Mads Ager wrote:
> bug_cleanup

Done.