Fixing an issue where optional parameters were having their types dropped.

Fixing an issue where optional parameters were having their types dropped.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=14799

[sra1, 2012-11-09 21:34:41]

https://codereview.chromium.org/11359142/diff/1/sdk/lib/html/scripts/systemht...
File sdk/lib/html/scripts/systemhtml.py (left):

https://codereview.chromium.org/11359142/diff/1/sdk/lib/html/scripts/systemht...
sdk/lib/html/scripts/systemhtml.py:715: param_type = 'dynamic'
What is the effect of removing this on code size in checked mode?  I believe
that the compiler is still dumb enough that it will be a size and perf hit.

https://codereview.chromium.org/11359142/diff/1/sdk/lib/html/scripts/systemht...
File sdk/lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11359142/diff/1/sdk/lib/html/scripts/systemht...
sdk/lib/html/scripts/systemhtml.py:679: CHECKS=' && '.join(checks))
Can you put this back?

https://codereview.chromium.org/11359142/diff/1/sdk/lib/html/scripts/systemht...
sdk/lib/html/scripts/systemhtml.py:742: checks.append('(?%s && %s is %s)' %
(parameter_name, parameter_name, test_type))
This was not a null-means-missing check.
If you explicitly pass null, that null matches any type.

Given
foo(Widget w, int x);
foo(String s, String y);

foo(null, 4) must match the first overload.

openCursor(null, 'prevunique') was historically sensitive to this.

[blois, 2012-11-09 23:20:41]

https://codereview.chromium.org/11359142/diff/1/sdk/lib/html/scripts/systemht...
File sdk/lib/html/scripts/systemhtml.py (left):

https://codereview.chromium.org/11359142/diff/1/sdk/lib/html/scripts/systemht...
sdk/lib/html/scripts/systemhtml.py:715: param_type = 'dynamic'
On 2012/11/09 21:34:41, sra1 wrote:
> What is the effect of removing this on code size in checked mode?  I believe
> that the compiler is still dumb enough that it will be a size and perf hit.

Done.

https://codereview.chromium.org/11359142/diff/1/sdk/lib/html/scripts/systemht...
File sdk/lib/html/scripts/systemhtml.py (right):

https://codereview.chromium.org/11359142/diff/1/sdk/lib/html/scripts/systemht...
sdk/lib/html/scripts/systemhtml.py:679: CHECKS=' && '.join(checks))
On 2012/11/09 21:34:41, sra1 wrote:
> Can you put this back?

Done :)

[sra1, 2012-11-10 01:31:21]

lgtm