Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 11359101: Use Socket.read instead of Socket.readList in HTTP (Closed)

Created:
8 years, 1 month ago by Søren Gjesse
Modified:
8 years, 1 month ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use Socket.read instead of Socket.readList in HTTP R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M sdk/lib/io/http_impl.dart View 1 chunk +3 lines, -9 lines 0 comments Download
M tests/standalone/io/http_server_socket_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 1 month ago (2012-11-08 09:40:29 UTC) #1
Mads Ager (google)
8 years, 1 month ago (2012-11-08 09:45:27 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698