Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 11359070: Eliminate faulty override test (Closed)

Created:
8 years, 1 month ago by hausner
Modified:
8 years, 1 month ago
Reviewers:
regis, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Eliminate faulty override test Fix issue 3859 Committed: https://code.google.com/p/dart/source/detail?r=14587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M tests/language/bad_override_test.dart View 2 chunks +4 lines, -10 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hausner
8 years, 1 month ago (2012-11-06 18:50:26 UTC) #1
hausner
TBR=regis
8 years, 1 month ago (2012-11-06 18:57:16 UTC) #2
regis
LGTM
8 years, 1 month ago (2012-11-06 19:28:33 UTC) #3
ahe
This does not look good to me. The code should have been preserved, but converted ...
8 years, 1 month ago (2012-11-06 19:38:33 UTC) #4
hausner
Good point. I will do that.
8 years, 1 month ago (2012-11-06 21:21:18 UTC) #5
ahe
8 years, 1 month ago (2012-11-06 21:23:43 UTC) #6
Thank you!

Powered by Google App Engine
This is Rietveld 408576698