Issue 11359068: Do not use hack around aborting loop body for a do/while.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11359068: Do not use hack around aborting loop body for a do/while. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
Lasse Reichstein Nielsen, floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not use hack around aborting loop body for a do/while. Committed: https://code.google.com/p/dart/source/detail?r=14563

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -37 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		5 chunks	+68 lines, -35 lines	0 comments	Download
	M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/11359068/diff/1003/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right): https://codereview.chromium.org/11359068/diff/1003/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart#newcode920 sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:920: bool isConditionExpression = condition == null bool isConditionExpression ...

8 years, 1 month ago (2012-11-06 12:13:33 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-06 12:19:14 UTC) #3

Thanks Florian

https://codereview.chromium.org/11359068/diff/1003/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/11359068/diff/1003/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:920: bool
isConditionExpression = condition == null
On 2012/11/06 12:13:33, floitsch wrote:
> bool isConditionExpression = (condition == null) || isJSCondition(condition);
> ?

Done.

Expand Messages | Collapse Messages

Issue 11359068: Do not use hack around aborting loop body for a do/while. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages