Issue 11359059: Fix mirrors move errors.

Issue 11359059: Fix mirrors move errors. (Closed)

Created:
8 years, 1 month ago by Johnni Winther

Modified:
8 years, 1 month ago

Reviewers:
ahe

CC:
reviews_dartlang.org, Andrei Mouravski

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix move errors. Committed: https://code.google.com/p/dart/source/detail?r=14557

Patch Set 2 : Updated cf. comments #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -29 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart	View	1	1 chunk	+16 lines, -18 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/mirrors.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/mirrors_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	utils/apidoc/apidoc.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	utils/apidoc/html_diff.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

lgtm https://codereview.chromium.org/11359059/diff/1/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart File sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart (right): https://codereview.chromium.org/11359059/diff/1/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart#newcode25 sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:25: // TODO(rnystrom): Use "package:" URL (#4968). I don't ...

8 years, 1 month ago (2012-11-06 09:34:26 UTC) #2

Johnni Winther

8 years, 1 month ago (2012-11-06 10:17:10 UTC) #3

https://codereview.chromium.org/11359059/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart
(right):

https://codereview.chromium.org/11359059/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:25: //
TODO(rnystrom): Use "package:" URL (#4968).
On 2012/11/06 09:34:26, ahe wrote:
> I don't think this comment applies.

Removed.

https://codereview.chromium.org/11359059/diff/1/sdk/lib/_internal/dartdoc/lib...
File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right):

https://codereview.chromium.org/11359059/diff/1/sdk/lib/_internal/dartdoc/lib...
sdk/lib/_internal/dartdoc/lib/dartdoc.dart:24: // TODO(rnystrom): Use "package:"
URL (#4968).
On 2012/11/06 09:34:26, ahe wrote:
> I don't think so.

Removed.

Expand Messages | Collapse Messages