Issue 11359005: Cleanup run on DartDoc tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11359005: Cleanup run on DartDoc tests. (Closed)

Created:
8 years, 1 month ago by Andrei Mouravski

Modified:
8 years, 1 month ago

Reviewers:
gram, siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup run on DartDoc tests. Committed: https://code.google.com/p/dart/source/detail?r=14361

Patch Set 1 #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -17 lines)			Patch
M	pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/dartdoc/test/dartdoc_search_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/dartdoc/test/dartdoc_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	pkg/dartdoc/test/markdown_test.dart	View	1 chunk	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

https://codereview.chromium.org/11359005/diff/1/pkg/dartdoc/test/markdown_test.dart File pkg/dartdoc/test/markdown_test.dart (right): https://codereview.chromium.org/11359005/diff/1/pkg/dartdoc/test/markdown_test.dart#newcode6 pkg/dartdoc/test/markdown_test.dart:6: library markdown_tests; The test harness framework is not yet ...

8 years, 1 month ago (2012-10-31 20:25:37 UTC) #3

Andrei Mouravski

8 years, 1 month ago (2012-10-31 20:41:21 UTC) #4

Ah, okay. Thanks, Siva.

On 2012/10/31 20:25:37, siva wrote:
>
https://codereview.chromium.org/11359005/diff/1/pkg/dartdoc/test/markdown_tes...
> File pkg/dartdoc/test/markdown_test.dart (right):
> 
>
https://codereview.chromium.org/11359005/diff/1/pkg/dartdoc/test/markdown_tes...
> pkg/dartdoc/test/markdown_test.dart:6: library markdown_tests;
> The test harness framework is not yet setup to handle
> the new library/import syntax.
> 
> See issue 6383 http://code.google.com/p/dart/issues/detail?id=6383
> 
> Until that is fixed you should probably keep the old syntax.

Expand Messages | Collapse Messages