Add a getter interceptor to the new interceptor scheme. Also cleanup the "this" that turns into a r…

Add a getter interceptor to the new interceptor scheme. Also cleanup the "this" that turns into a receiver hack, so that a method in an intercepted class can call another method of itself.
Committed: https://code.google.com/p/dart/source/detail?r=14876

[floitsch, 2012-11-13 18:12:24]

LGTM.

https://codereview.chromium.org/11358217/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11358217/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2297: if (interceptor
== backend.getInterceptorMethod && interceptor != null) {
remove "&& interceptor != null".

https://codereview.chromium.org/11358217/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2302: if
(backend.isInterceptorClass(currentElement.getEnclosingClass())) {
don't you need to verify that the receiver is of the same class as 'this' ?

https://codereview.chromium.org/11358217/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2323: } else {
Eventually (once there is no old deprecated interceptor anymore), I would prefer
to inverse the order of the test:
if (interceptor == null) {
  ...
} else {
  assert(interceptor == backend.getInterceptorMethod);
  ...
}

https://codereview.chromium.org/11358217/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2380: if (interceptor
!= null && interceptor == backend.getInterceptorMethod) {
ditto. remove "interceptor != null".

https://codereview.chromium.org/11358217/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2656:
inputs.add(thisInstruction);
ditto:
- don't you need to verify that the node's receiver is the same type as this.
Also visiting the receiver might have a side-effect.

[ngeoffray, 2012-11-14 08:44:58]

Thanks Florian

https://codereview.chromium.org/11358217/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11358217/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2297: if (interceptor
== backend.getInterceptorMethod && interceptor != null) {
On 2012/11/13 18:12:24, floitsch wrote:
> remove "&& interceptor != null".

No, I want to make sure we don't have to have getInterceptor (for eg unit
tests). Long term, I think I'll just change getStaticInterceptor into
"isIntercepted".

https://codereview.chromium.org/11358217/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2302: if
(backend.isInterceptorClass(currentElement.getEnclosingClass())) {
On 2012/11/13 18:12:24, floitsch wrote:
> don't you need to verify that the receiver is of the same class as 'this' ?

Yes, very good catch. I need to check that the receiver is the extra parameter.

https://codereview.chromium.org/11358217/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2656:
inputs.add(thisInstruction);
On 2012/11/13 18:12:24, floitsch wrote:
> ditto:
> - don't you need to verify that the node's receiver is the same type as this.
> Also visiting the receiver might have a side-effect.

In this situation there is no receiver.