Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 11358175: Do not generate multiple tests for vm options. (Closed)

Created:
8 years, 1 month ago by Anton Muhin
Modified:
8 years, 1 month ago
Reviewers:
ahe, Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not generate multiple tests for vm options. R=ahe@google.com,ager@google.com BUG=6436 Committed: https://code.google.com/p/dart/source/detail?r=14786

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/testing/dart/test_suite.dart View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Anton Muhin
8 years, 1 month ago (2012-11-09 12:59:07 UTC) #1
ahe
LGTM, but I also have an alternative suggestion. You could change getVmOptions in test_suite.dart: if ...
8 years, 1 month ago (2012-11-09 16:14:28 UTC) #2
Mads Ager (google)
lgtm, I agree with Peter that maybe we should filter in getVmOptions instead.
8 years, 1 month ago (2012-11-12 08:32:48 UTC) #3
Anton Muhin
ptal
8 years, 1 month ago (2012-11-12 10:09:58 UTC) #4
Mads Ager (google)
lgtm
8 years, 1 month ago (2012-11-12 11:43:32 UTC) #5
ahe
8 years, 1 month ago (2012-11-12 13:08:15 UTC) #6
LGTM!

Powered by Google App Engine
This is Rietveld 408576698