Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 11358116: Fix memory growth in simple http server. (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)
Modified:
8 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix memory growth in simple http server. The issue was that connections were not always removed from the list of active connections in the http server. R=sgjesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M sdk/lib/io/http_impl.dart View 3 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
8 years, 1 month ago (2012-11-06 14:52:35 UTC) #1
Mads Ager (google)
Bombarded this with requests for an hour and a half with no memory growth.
8 years, 1 month ago (2012-11-06 14:57:05 UTC) #2
Søren Gjesse
8 years, 1 month ago (2012-11-06 15:31:49 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698