Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 11358045: Update test utils to generate wrappers with new library syntax and handle (Closed)

Created:
8 years, 1 month ago by gram
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update test utils to generate wrappers with new library syntax and handle tests with new library syntax. Committed: https://code.google.com/p/dart/source/detail?r=14437

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M tools/testing/dart/browser_test.dart View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gram
Separated out as per Peter's suggestion.
8 years, 1 month ago (2012-11-01 20:55:40 UTC) #1
Siggi Cherem (dart-lang)
not sure if matching things exactly is necessary given that we'll soon deprecate #source, but ...
8 years, 1 month ago (2012-11-01 21:02:04 UTC) #2
ahe
lgtm https://codereview.chromium.org/11358045/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/11358045/diff/1/tools/testing/dart/test_suite.dart#newcode984 tools/testing/dart/test_suite.dart:984: const RegExp(r"^[#]?(source|part|import|resource)", multiLine: true); On 2012/11/01 21:02:04, Siggi ...
8 years, 1 month ago (2012-11-01 21:08:42 UTC) #3
gram
PTAL https://codereview.chromium.org/11358045/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/11358045/diff/1/tools/testing/dart/test_suite.dart#newcode984 tools/testing/dart/test_suite.dart:984: const RegExp(r"^[#]?(source|part|import|resource)", multiLine: true); Yes, these false positives ...
8 years, 1 month ago (2012-11-01 21:20:48 UTC) #4
Siggi Cherem (dart-lang)
lgtm
8 years, 1 month ago (2012-11-01 21:22:57 UTC) #5
ahe
8 years, 1 month ago (2012-11-01 21:23:44 UTC) #6
lgtm

https://codereview.chromium.org/11358045/diff/6001/tools/testing/dart/browser...
File tools/testing/dart/browser_test.dart (right):

https://codereview.chromium.org/11358045/diff/6001/tools/testing/dart/browser...
tools/testing/dart/browser_test.dart:58: import
'${dartHome.append('pkg/unittest/lib/unittest.dart')}' as unittest;
Perhaps you should remove the '/lib' part until the other CL lands.

Powered by Google App Engine
This is Rietveld 408576698