Issue 11358042: Make new audionode names backwards compatible.

Issue 11358042: Make new audionode names backwards compatible. (Closed)

Created:
8 years, 1 month ago by Emily Fortuna

Modified:
8 years, 1 month ago

Reviewers:
Anton Muhin, sra1, blois

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make new audionode names backwards compatible. Committed: https://code.google.com/p/dart/source/detail?r=14432

Patch Set 1 #

Total comments: 6

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -10 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View	4 chunks	+36 lines, -4 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	1 chunk	+0 lines, -2 lines	2 comments	Download
M	lib/html/scripts/systemhtml.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	lib/html/templates/html/impl/impl_AudioContext.darttemplate	View	1 chunk	+41 lines, -0 lines	4 comments	Download
M	tests/html/audiocontext_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/html.status	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://codereview.chromium.org/11358042/diff/1/lib/html/templates/html/impl/impl_AudioContext.darttemplate File lib/html/templates/html/impl/impl_AudioContext.darttemplate (right): https://codereview.chromium.org/11358042/diff/1/lib/html/templates/html/impl/impl_AudioContext.darttemplate#newcode17 lib/html/templates/html/impl/impl_AudioContext.darttemplate:17: numberOfOutputChannels]) { One would think there would be a ...

8 years, 1 month ago (2012-11-01 18:38:58 UTC) #1

sra1

https://codereview.chromium.org/11358042/diff/1/lib/html/templates/html/impl/impl_AudioContext.darttemplate File lib/html/templates/html/impl/impl_AudioContext.darttemplate (right): https://codereview.chromium.org/11358042/diff/1/lib/html/templates/html/impl/impl_AudioContext.darttemplate#newcode8 lib/html/templates/html/impl/impl_AudioContext.darttemplate:8: void createGain() { not 'void'. GainNode? https://codereview.chromium.org/11358042/diff/1/lib/html/templates/html/impl/impl_AudioContext.darttemplate#newcode10 lib/html/templates/html/impl/impl_AudioContext.darttemplate:10: return ...

8 years, 1 month ago (2012-11-01 20:59:40 UTC) #3

sra1

https://codereview.chromium.org/11358042/diff/1/lib/html/dartium/html_dartium.dart File lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/11358042/diff/1/lib/html/dartium/html_dartium.dart#oldcode1029 lib/html/dartium/html_dartium.dart:1029: -// WARNING: Do not edit - generated code. Where ...

8 years, 1 month ago (2012-11-01 21:00:34 UTC) #4

Emily Fortuna

8 years, 1 month ago (2012-11-01 22:11:18 UTC) #5

I made a new CL making the fixes Stephen found.

https://codereview.chromium.org/11358042/diff/1/lib/html/dartium/html_dartium...
File lib/html/dartium/html_dartium.dart (left):

https://codereview.chromium.org/11358042/diff/1/lib/html/dartium/html_dartium...
lib/html/dartium/html_dartium.dart:1029: -// WARNING: Do not edit - generated
code.
On 2012/11/01 21:00:34, sra1 wrote:
> Where is this go?

I just ran go.sh, and suspected that maybe it had been an extra that got in, but
apparently not. I  just reran go.sh and it's back in...

Expand Messages | Collapse Messages