Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 11358039: Lightweight asynchronous test helper. (Closed)

Created:
8 years, 1 month ago by ahe
Modified:
8 years, 1 month ago
Reviewers:
ricow1, kasperl
CC:
reviews_dartlang.org, gram
Visibility:
Public.

Description

Lightweight asynchronous test helper. Committed: https://code.google.com/p/dart/source/detail?r=14452

Patch Set 1 : #

Patch Set 2 : Update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -1 line) Patch
M dart/pkg/unittest/test_controller.js View 1 chunk +6 lines, -1 line 0 comments Download
A dart/tests/compiler/dart2js_extra/async_helper.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M dart/tests/compiler/dart2js_extra/dart2js_extra.status View 1 1 chunk +9 lines, -0 lines 0 comments Download
A dart/tests/compiler/dart2js_extra/timer_negative_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download
A dart/tests/compiler/dart2js_extra/timer_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ahe
This is not meant to replace unittest, but we compiler engineers really prefer small functions ...
8 years, 1 month ago (2012-11-01 18:12:44 UTC) #1
ricow1
8 years, 1 month ago (2012-11-01 18:16:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698