Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 11358024: Changes outside pkg/ and lib/ for directory refactoring (Closed)

Created:
8 years, 1 month ago by dgrove
Modified:
8 years, 1 month ago
Reviewers:
ahe, Ivan Posva
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Changes outside pkg/ and lib/ for directory refactoring Committed: https://code.google.com/p/dart/source/detail?r=14475

Patch Set 1 #

Patch Set 2 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -271 lines) Patch
M runtime/bin/bin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/crypto_sources.gypi View 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/bin/json_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/uri_sources.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/bin/utf_sources.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/lib/mirrors_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/benchmark_test.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/vm.gypi View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/backend_htype_list_test.dart View 1 1 chunk +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/begin_end_token_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/call_site_type_inferer_static_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/call_site_type_inferer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 1 chunk +9 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/compiler_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/erroneous_element_test.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/field_type_inferer_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/find_my_name_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/link_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/metadata_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mini_parser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mirrors_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 1 chunk +8 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 1 chunk +9 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/parser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/return_type_inferer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/scanner_offset_length_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/scanner_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/source_mapping_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 1 chunk +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_equals_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 1 chunk +6 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/uri_extras_test.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/value_range2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/crypto/base64_test.dart View 1 chunk +1 line, -1 line 2 comments Download
M tests/standalone/io/http_date_test.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M tests/standalone/io/http_headers_test.dart View 1 1 chunk +10 lines, -10 lines 0 comments Download
M tests/standalone/io/http_parser_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/mime_multipart_parser_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/url_encoding_test.dart View 1 1 chunk +10 lines, -10 lines 0 comments Download
M tests/standalone/io/web_socket_protocol_processor_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/utils/dummy_compiler_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/utils/recursive_import_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/utils/uri_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/create_sdk.py View 6 chunks +22 lines, -45 lines 2 comments Download
M utils/apidoc/apidoc.dart View 1 4 chunks +13 lines, -13 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/apidoc/html_diff.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M utils/apidoc/scripts/list_files.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/compiler/build_helper.dart View 1 2 chunks +8 lines, -7 lines 0 comments Download
M utils/compiler/compiler.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgrove
I decided to break out the changes outside of pkg/ and lib/ prior to this ...
8 years, 1 month ago (2012-10-31 22:59:22 UTC) #1
dgrove
On 2012/10/31 22:59:22, dgrove wrote: > I decided to break out the changes outside of ...
8 years, 1 month ago (2012-11-01 03:39:21 UTC) #2
Ivan Posva
LGTM -ip http://codereview.chromium.org/11358024/diff/3001/tests/standalone/crypto/base64_test.dart File tests/standalone/crypto/base64_test.dart (right): http://codereview.chromium.org/11358024/diff/3001/tests/standalone/crypto/base64_test.dart#newcode5 tests/standalone/crypto/base64_test.dart:5: #source("../../../sdk/lib/io/base64.dart"); Why is this not being updated ...
8 years, 1 month ago (2012-11-01 21:56:29 UTC) #3
dgrove
http://codereview.chromium.org/11358024/diff/3001/tests/standalone/crypto/base64_test.dart File tests/standalone/crypto/base64_test.dart (right): http://codereview.chromium.org/11358024/diff/3001/tests/standalone/crypto/base64_test.dart#newcode5 tests/standalone/crypto/base64_test.dart:5: #source("../../../sdk/lib/io/base64.dart"); On 2012/11/01 21:56:29, Ivan Posva wrote: > Why ...
8 years, 1 month ago (2012-11-01 23:24:59 UTC) #4
ahe
8 years, 1 month ago (2012-11-02 08:15:24 UTC) #5
LGTM. Nice with the added bonus of fixing up library syntax!

https://codereview.chromium.org/11358024/diff/3001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/11358024/diff/3001/tools/create_sdk.py#newcod...
tools/create_sdk.py:275: if (utils.GuessOS() == 'win32'):
FYI: This should be temporary. We will move these scripts to sdk/bin.

https://codereview.chromium.org/11358024/diff/3001/tools/create_sdk.py#newcod...
tools/create_sdk.py:288: ReplaceInFiles([join(SDK_tmp, 'lib', '_internal',
'dartdoc', 'lib', 'dartdoc.dart')],
Long line.

Powered by Google App Engine
This is Rietveld 408576698