Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1135613002: Set CacheEntry.target in the contructor. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Set CacheEntry.target in the contructor. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -74 lines) Patch
M pkg/analyzer/lib/src/context/cache.dart View 8 chunks +16 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 22 chunks +77 lines, -57 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-07 20:47:40 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-07 21:03:15 UTC) #2
scheglov
5 years, 7 months ago (2015-05-07 21:05:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45619 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698