Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 1135173008: Fix for bug 23484 (obscure error when a compilation error happens during Object::Init()) (Closed)

Created:
5 years, 7 months ago by siva
Modified:
5 years, 7 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for bug 23484 (obscure error when a compilation error happens during Object::Init()) BUG=23484 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b9b5a05265d1087431351b80c246bdee40203d85

Patch Set 1 #

Patch Set 2 : fix-comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M runtime/vm/bootstrap.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +20 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
siva
5 years, 7 months ago (2015-05-18 23:59:33 UTC) #2
Cutch
lgtm
5 years, 7 months ago (2015-05-19 00:35:28 UTC) #3
siva
5 years, 7 months ago (2015-05-19 18:19:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b9b5a05265d1087431351b80c246bdee40203d85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698