Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Issue 1135073004: Fix for 'Create part' Quick Fix. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for 'Create part' Quick Fix. 1. NonExistingSource.modificationStamp should return -1. 2. NonExistingSource.fullName should be always an absolute path, not a URI. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4936eb8d5dbc1510340fdb3df06abdaa2034a9c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -30 lines) Patch
M pkg/analysis_server/lib/src/services/correction/util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/source/package_map_resolver.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 2 chunks +13 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/source/package_map_resolver_test.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-18 18:50:35 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-18 18:54:02 UTC) #2
scheglov
5 years, 7 months ago (2015-05-18 18:55:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4936eb8d5dbc1510340fdb3df06abdaa2034a9c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698