Issue 1134873003: Move getErrors() to DartWorkManager, report errors in ChangeNotice(s).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1134873003: Move getErrors() to DartWorkManager, report errors in ChangeNotice(s). (Closed)

Created:
5 years, 7 months ago by scheglov

Modified:
5 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Move getErrors() to DartWorkManager, report errors in ChangeNotice(s). R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45766

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+152 lines, -40 lines)			Patch
M	pkg/analyzer/lib/src/context/context.dart	View	1 chunk	+1 line, -21 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart_work_manager.dart	View	4 chunks	+80 lines, -14 lines	1 comment	Download
M	pkg/analyzer/test/src/task/dart_work_manager_test.dart	View	4 chunks	+71 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

Thanks for the ping. I must have missed seeing it yesterday. https://codereview.chromium.org/1134873003/diff/1/pkg/analyzer/lib/src/task/dart_work_manager.dart File pkg/analyzer/lib/src/task/dart_work_manager.dart (right): ...

5 years, 7 months ago (2015-05-13 16:15:10 UTC) #3

scheglov

5 years, 7 months ago (2015-05-13 16:28:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45766 (presubmit successful).

Expand Messages | Collapse Messages