Issue 11348380: language.status updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348380: language.status updated (Closed)

Created:
8 years ago by Johnni Winther

Modified:
8 years ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

language.status updated Committed: https://code.google.com/p/dart/source/detail?r=15687

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tests/language/language.status	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years ago (2012-12-04 16:23:14 UTC) #2

Message was sent while issue was closed.

LGTM as it is already submitted.

https://codereview.chromium.org/11348380/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/11348380/diff/1/tests/language/language.statu...
tests/language/language.status:529: import_core_prefix_test: Pass
This marks the test as flaky.  It should be:

[ $compiler == dart2dart && $unminified ]
import_core_prefix_test: Fail
etc...

Expand Messages | Collapse Messages