Issue 11348376: Report errors when factory redirection is used in non-factory methods.

Issue 11348376: Report errors when factory redirection is used in non-factory methods. (Closed)

Created:
8 years ago by ahe

Modified:
8 years ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Report errors when factory redirection is used in non-factory methods. Committed: https://code.google.com/p/dart/source/detail?r=15722

Patch Set 2 : Address review comments #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -5 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1	1 chunk	+10 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/warnings.dart	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	dart/tests/language/language_dart2js.status	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/11348376/diff/1/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/11348376/diff/1/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2023 dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:2023: Diagnostic.ERROR); Should this be Diagnostic.INFO? https://codereview.chromium.org/11348376/diff/1/dart/sdk/lib/_internal/compiler/implementation/warnings.dart File dart/sdk/lib/_internal/compiler/implementation/warnings.dart ...

8 years ago (2012-12-04 13:13:20 UTC) #2

ahe

8 years ago (2012-12-05 08:04:21 UTC) #3

Thank you, Johnni!

https://codereview.chromium.org/11348376/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
(right):

https://codereview.chromium.org/11348376/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:2023:
Diagnostic.ERROR);
On 2012/12/04 13:13:21, Johnni Winther wrote:
> Should this be Diagnostic.INFO?

Done.

https://codereview.chromium.org/11348376/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/11348376/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/warnings.dart:339: "Error:
factory redirection only allowed in factories.");
On 2012/12/04 13:13:21, Johnni Winther wrote:
> We need a style guide for capitalization of the first word and first word
after
> a colon. I prefer upper case in both cases, so 'factory' => 'Factory'.

Done.

Expand Messages | Collapse Messages