Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 11348332: Make directory renaming more resilient on Windows. (Closed)

Created:
8 years ago by Bob Nystrom
Modified:
8 years ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make directory renaming more resilient on Windows. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15608

Patch Set 1 #

Patch Set 2 : Only retry on Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M utils/pub/io.dart View 1 1 chunk +26 lines, -1 line 0 comments Download
M utils/tests/pub/pub.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
8 years ago (2012-11-30 22:19:43 UTC) #1
nweiz
LGTM We probably should only do this on Windows, though.
8 years ago (2012-11-30 22:22:32 UTC) #2
Bob Nystrom
8 years ago (2012-11-30 22:27:18 UTC) #3
On 2012/11/30 22:22:32, nweiz wrote:
> LGTM
> 
> We probably should only do this on Windows, though.

Done.

Powered by Google App Engine
This is Rietveld 408576698