Issue 11348309: Keep around a copy of the http.Request that triggered each Response.

Issue 11348309: Keep around a copy of the http.Request that triggered each Response. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Keep around a copy of the http.Request that triggered each Response. Committed: https://code.google.com/p/dart/source/detail?r=15555

Patch Set 1 #

Total comments: 4

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -9 lines)			Patch
M	pkg/http/lib/src/base_response.dart	View	2 chunks	+7 lines, -1 line	2 comments	Download
M	pkg/http/lib/src/io_client.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/http/lib/src/mock_client.dart	View	3 chunks	+18 lines, -2 lines	0 comments	Download
M	pkg/http/lib/src/response.dart	View	5 chunks	+8 lines, -2 lines	2 comments	Download
M	pkg/http/lib/src/streamed_response.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	pkg/http/test/mock_client_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/curl_client.dart	View	3 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Please add a test. Otherwise LGTM. https://codereview.chromium.org/11348309/diff/1/pkg/http/lib/src/base_response.dart File pkg/http/lib/src/base_response.dart (right): https://codereview.chromium.org/11348309/diff/1/pkg/http/lib/src/base_response.dart#newcode17 pkg/http/lib/src/base_response.dart:17: final BaseRequest request; ...

8 years ago (2012-11-29 23:57:04 UTC) #2

nweiz

8 years ago (2012-11-30 00:08:53 UTC) #3

https://codereview.chromium.org/11348309/diff/1/pkg/http/lib/src/base_respons...
File pkg/http/lib/src/base_response.dart (right):

https://codereview.chromium.org/11348309/diff/1/pkg/http/lib/src/base_respons...
pkg/http/lib/src/base_response.dart:17: final BaseRequest request;
On 2012/11/29 23:57:04, Bob Nystrom wrote:
> Pedantic, but you should have a test that you can access this property and
that
> it returns the same object you passed to the constructor.

Done.

https://codereview.chromium.org/11348309/diff/1/pkg/http/lib/src/response.dart
File pkg/http/lib/src/response.dart (right):

https://codereview.chromium.org/11348309/diff/1/pkg/http/lib/src/response.dar...
pkg/http/lib/src/response.dart:32: {BaseRequest request: null,
On 2012/11/29 23:57:04, Bob Nystrom wrote:
> null is the default default value, so you can omit it here. Just:
> 
>    {BaseRequest request,

Done.

Expand Messages | Collapse Messages