Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 11348295: Fix issue 7005: (Closed)

Created:
8 years ago by Ivan Posva
Modified:
8 years ago
CC:
reviews_dartlang.org, rmacnak_gmail.com
Visibility:
Public.

Description

Fix issue 7005: - Preserve exported symbols when call strip on Mac OS X. - Do not call GuessOS() repeatedly. Committed: https://code.google.com/p/dart/source/detail?r=15504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M tools/create_sdk.py View 6 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
8 years ago (2012-11-29 09:16:43 UTC) #1
Mads Ager (google)
LGTM, thanks for the fix Ivan!
8 years ago (2012-11-29 09:17:49 UTC) #2
dgrove
8 years ago (2012-11-29 16:03:39 UTC) #3
Message was sent while issue was closed.
LGTM!

Powered by Google App Engine
This is Rietveld 408576698