Issue 11348283: Add flag 'implements' to class, it is set anytime someone implements this class. This is a way to r…

Issue 11348283: Add flag 'implements' to class, it is set anytime someone implements this class. This is a way to r… (Closed)

Created:
8 years ago by srdjan

Modified:
8 years ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add flag 'implements' to class, it is set anytime someone implements this class. This is a way to recognize implicit interfaces in order to improve class checks. Committed: https://code.google.com/p/dart/source/detail?r=15477

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -4 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.h	View		2 chunks	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/object_test.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/scanner_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM with suggestion. https://codereview.chromium.org/11348283/diff/1/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/11348283/diff/1/runtime/vm/class_finalizer.cc#newcode175 runtime/vm/class_finalizer.cc:175: MarkImplementedClasses(class_array); Instead of adding another pass, ...

8 years ago (2012-11-28 22:32:17 UTC) #2

srdjan

8 years ago (2012-11-28 22:43:50 UTC) #3

https://codereview.chromium.org/11348283/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/11348283/diff/1/runtime/vm/class_finalizer.cc...
runtime/vm/class_finalizer.cc:175: MarkImplementedClasses(class_array);
On 2012/11/28 22:32:17, regis wrote:
> Instead of adding another pass, you could mark interfaces directly inside
> ResolveInterfaces().

Done.

https://codereview.chromium.org/11348283/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11348283/diff/1/runtime/vm/object.cc#newcode1992
runtime/vm/object.cc:1992: 
On 2012/11/28 22:32:17, regis wrote:
> Did you remove the blank line by accident?

Done.

Expand Messages | Collapse Messages