Issue 11348270: Emit constants using ASTs, try 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348270: Emit constants using ASTs, try 2. (Closed)

Created:
8 years ago by sra1

Modified:
8 years ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Emit constants using ASTs, try 2. The ad-hoc name '$' in addParameterStub captured isolate accesses, also via '$'. Renamed the ad-hoc name to '$receiver'. Committed: https://code.google.com/p/dart/source/detail?r=15437

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+302 lines, -221 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart	View	2 chunks	+262 lines, -158 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	6 chunks	+35 lines, -21 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1 chunk	+4 lines, -37 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages