Context fix for linting.

(Was: Linter analysis plugin.)

FWIW: Lint rule plugins are moving to their (rightful) home in the linter proper.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45698

[pquitslund, 2015-05-08 22:13:35]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[pquitslund, 2015-05-08 22:13:36]

Server and CLI bits next.

[Brian Wilkerson, 2015-05-08 22:16:48]

LGTM

[kevmoo, 2015-05-08 22:19:18]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-05-08 22:19:19]

DBC

https://codereview.chromium.org/1134823002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1134823002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/engine.dart:19: import
'package:analyzer/src/plugin/linter_plugin.dart';
I don't see this file as part of the CL. Missing?

[pquitslund, 2015-05-08 22:25:46]

Added missed files.

PTAL.

[kevmoo, 2015-05-08 22:30:01]

Also: doesn't the linter package have to be brought in via DEPS updates, too?

https://codereview.chromium.org/1134823002/diff/60001/pkg/analyzer/lib/plugin...
File pkg/analyzer/lib/plugin/linter.dart (right):

https://codereview.chromium.org/1134823002/diff/60001/pkg/analyzer/lib/plugin...
pkg/analyzer/lib/plugin/linter.dart:14: /// analysis tasks with the analysis
engine. The object used as an extension must
long line

https://codereview.chromium.org/1134823002/diff/60001/pkg/analyzer/lib/src/pl...
File pkg/analyzer/lib/src/plugin/linter_plugin.dart (right):

https://codereview.chromium.org/1134823002/diff/60001/pkg/analyzer/lib/src/pl...
pkg/analyzer/lib/src/plugin/linter_plugin.dart:22: /// A plugin that defines the
extension points and extensions that are inherently
long line

https://codereview.chromium.org/1134823002/diff/60001/pkg/analyzer/lib/src/pl...
pkg/analyzer/lib/src/plugin/linter_plugin.dart:48: /// The extension point that
allows plugins to register new lint rules tasks with
long line

[Brian Wilkerson, 2015-05-08 22:32:45]

LGTM

[pquitslund, 2015-05-08 22:39:20]

Fixed.

As for DEPS, that's another good catch.  Please hold for another CL. :)

https://codereview.chromium.org/1134823002/diff/60001/pkg/analyzer/lib/plugin...
File pkg/analyzer/lib/plugin/linter.dart (right):

https://codereview.chromium.org/1134823002/diff/60001/pkg/analyzer/lib/plugin...
pkg/analyzer/lib/plugin/linter.dart:14: /// analysis tasks with the analysis
engine. The object used as an extension must
On 2015/05/08 22:30:00, kevmoo wrote:
> long line

Fixed.

https://codereview.chromium.org/1134823002/diff/60001/pkg/analyzer/lib/src/pl...
File pkg/analyzer/lib/src/plugin/linter_plugin.dart (right):

https://codereview.chromium.org/1134823002/diff/60001/pkg/analyzer/lib/src/pl...
pkg/analyzer/lib/src/plugin/linter_plugin.dart:22: /// A plugin that defines the
extension points and extensions that are inherently
On 2015/05/08 22:30:00, kevmoo wrote:
> long line

Done.

https://codereview.chromium.org/1134823002/diff/60001/pkg/analyzer/lib/src/pl...
pkg/analyzer/lib/src/plugin/linter_plugin.dart:48: /// The extension point that
allows plugins to register new lint rules tasks with
On 2015/05/08 22:30:00, kevmoo wrote:
> long line

Done.

[pquitslund, 2015-05-08 22:39:23]

Fixed.

As for DEPS, that's another good catch.  Please hold for another CL. :)

[pquitslund, 2015-05-11 17:43:55]

Committed patchset #6 (id:100001) manually as r45698 (presubmit successful).