Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 11348216: Report parser error if a class isn't terminated by }. (Closed)

Created:
8 years ago by ahe
Modified:
8 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Report parser error if a class isn't terminated by }. Committed: https://code.google.com/p/dart/source/detail?r=15383

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 1 chunk +1 line, -0 lines 0 comments Download
M dart/tests/compiler/dart2js/parser_helper.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/parser_test.dart View 2 chunks +13 lines, -0 lines 0 comments Download
A dart/tests/language/class_syntax_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ahe
This cases isn't hit normally as it is rejected by [PartialParser.skipClassBody].
8 years ago (2012-11-23 18:57:48 UTC) #1
Johnni Winther
8 years ago (2012-11-23 20:59:08 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698